Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1038 dark mode dialog text color issue #1046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #1038 dark mode dialog text color issue #1046

wants to merge 3 commits into from

Conversation

crvdgc
Copy link

@crvdgc crvdgc commented May 6, 2024

Fixed two places where the button colors are hard-coded. Also changed AlertDialog's style so that the positive and negative buttons have proper text colors, instead of black.

Closes #1038.

@crvdgc crvdgc changed the title Fix #1038 dark mode text Fix #1038 dark mode dialog text color issue May 6, 2024
@oliexdev oliexdev requested review from oliexdev and removed request for oliexdev May 20, 2024 09:11
@oliexdev
Copy link
Owner

First of all thx for the PR. On which Android API did you tested it? I tried it with API level 33 and 23 and unfortunately it the text on the birhtday date picker on #1038 is still the same.

@crvdgc
Copy link
Author

crvdgc commented May 20, 2024 •
edited
Loading

On which Android API did you tested it?

I'm sorry, due to a change of computer, I lost the previous configuration for this project. I think it's automatically picked up by Android Studio, so it's very likely to be the latest one. (Sorry, I'm not very familiar with Android development as well.)

One thing I used to test the PR is to add a manual measurement without creating a user, which triggers this showNoSelectedUserDialog error. Before this PR, the buttons of that dialog in dark mode are black. This PR should at least fix them. Can you test if this is the case? If so, the birthday picker error may be a result of a missing change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor dark mode issue
2 participants
@crvdgc @oliexdev